refactor(front_vehicle_velocity_estimator): rework parameters #5241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuqi Huai <[email protected]>
github-actions
bot
added
type:documentation
YuqiHuai
changed the title
miursh
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5241 +/- ##
==========================================
+ Coverage 15.32% 15.35% +0.02%
==========================================
Files 1721 1721
Lines 118559 118300 -259
Branches 37995 37888 -107
==========================================
- Hits 18169 18160 -9
+ Misses 79657 79416 -241
+ Partials 20733 20724 -9
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
scepter914
requested changes
Oct 16, 2023
scepter914
reviewed
Oct 16, 2023
perception/front_vehicle_velocity_estimator/config/front_vehicle_velocity_estimator.param.yaml
Outdated
Show resolved
Hide resolved
scepter914
removed
the
run:build-and-test-differential
scepter914
requested changes
Nov 16, 2023
| @@ -28,7 +28,7 @@ This package can: | |||
| | `~/output/objects` | autoware_auto_perception_msgs/msg/DetectedObjects.msg | 3D detected object with twist. | | |||
| | `~/debug/nearest_neighbor_pointcloud` | sensor_msgs/msg/PointCloud2.msg | The pointcloud msg of nearest neighbor point. | | |||
|
|
|||
| ## Node parameter | |||
| ## Node Parameter | |||
There was a problem hiding this comment.
[Must]
This change is not necessary, so could you revert this change?
There is lack of uniformity in uppercase and lowercase between "Node Parameter" and "Core parameter".
kminoda
added
the
run:build-and-test-differential
7 tasks
|
This pull request has been automatically marked as stale because it has not had recent activity. |
|
Because this PR has stale label and front_vehicle_velocity_estimator will be deleted, so I close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ROS node configuration refactored according to Guideline.
Related links
None.
Tests performed
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to front_vehicle_velocity_estimatorros2 launch front_vehicle_velocity_estimator front_vehicle_velocity_estimator.launch.xmlNotes for reviewers
None.
Interface changes
configdeclare_parameterEffects on system behavior
None.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.